Skip to content

[cert-manager-1.18] CM-763: Fix unconditional update in user-defined network policy reconciliation #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

[cert-manager-1.18] CM-763: Fix unconditional update in user-defined network policy reconciliation #341

merged 1 commit into from
Oct 30, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 30, 2025

This is an automated cherry-pick of #339

/assign bharath-b-rh

@lunarwhite
Fix unconditional update in user-defined network policy
1f54e93 
to eliminate unnecessary reconciliation loops
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 30, 2025
Merged
3 tasks
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CM-763

In response to this:

This is an automated cherry-pick of #339

/assign bharath-b-rh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Oct 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@bharath-b-rh
Copy link
Contributor

bharath-b-rh commented Oct 30, 2025

This is an automated cherry-pick PR, hence adding all required labels
/lgtm
/approve
/label docs-approved
/label px-approved
/label qe-approved
/test fips-image-scan-operator
/test unit

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Oct 30, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references CM-763 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #339

/assign bharath-b-rh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@lunarwhite
Copy link
Member

lunarwhite commented Oct 30, 2025

We could wait until #340 merged first. Then trigger a retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2025

/retest-required

Remaining retests: 0 against base HEAD 602565d and 2 for PR HEAD 1f54e93 in total

@lunarwhite
Copy link
Member

lunarwhite commented Oct 30, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-tech-preview 1f54e93 link false /test e2e-operator-tech-preview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1e9c860 into openshift:cert-manager-1.18 Oct 30, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharath-b-rh bharath-b-rh Awaiting requested review from bharath-b-rh

@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer

Assignees

@bharath-b-rh bharath-b-rh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @bharath-b-rh @lunarwhite